MOVE_SELF handling renames the directory incorrectly

[facundo@…]

I have a path fully watched. Rename one directory from "test_dir", to "test_dir_renamed" (note that they "overlap").

So, it gets into process_IN_MOVE_SELF(), and tries to fix the paths that it has in the watch managers.

In the loop where it checks which paths to choose, it gets: "tests/home_dir/root/test_dir_renamed".

The src_path is:

tests/home_dir/root/test_dir

The dest_path is:

tests/home_dir/root/test_dir_renamed

And the code *incorrectly* renames it to:

tests/home_dir/root/test_dir_renamed/renamed

One way to avoid this overlapping issue is to add the "/" to the source_path, so you don't get in the trap of comparing with .startswith().

A patch is attached here that fixes the problem in the described way.

[facundo@…]

Patch that fixes the overlapping problem

[seb]

Hi Facundo,

I think your trick is the right way to fix this bug indeed, please pull  this commit.

Thanks for your patch.